Re: [PATCH] usb: dwc3: replace %p with %pK

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 17, 2017 at 04:02:33PM +0300, Felipe Balbi wrote:
> %p will leak kernel pointers, so let's not expose the information on
> dmesg and instead use %pK. %pK will only show the actual addresses if
> explicitly enabled under /proc/sys/kernel/kptr_restrict.
> 
> Signed-off-by: Felipe Balbi <felipe.balbi@xxxxxxxxxxxxxxx>
> ---
> 
> Inspired by a recent patch Greg posted. Note that I've kept
> tracepoints with %p because you already need admin rights to mount
> tracefs and/or debugfs. If folks think tracepoints should be changed
> to %pK too, let me know and I'll change the patch.

I don't think that tracepoints have to be changed, so this should be
fine for now.

Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

And care to mark this for stable?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux