On Tue, May 16, 2017 at 01:08:23AM +0300, Andrey Korolyov wrote:
> This patch adds support for recognition of ARM-USB-TINY(H) devices which are almost
> identical to ARM-USB-OCD(H) but lacking separate barrel jack and serial console.
Please wrap your commit messages at 72 cols or so.
> Signed-off-by: Andrey Korolyov <andrey@xxxxxxx>
> Cc: stable <stable@xxxxxxxxxxxxxxx>
> ---
And remember to include brief changelog here when updating a patch.
> drivers/usb/serial/ftdi_sio.c | 8 ++++----
> drivers/usb/serial/ftdi_sio_ids.h | 2 ++
> 2 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
> index d38780f..bd70c8b 100644
> --- a/drivers/usb/serial/ftdi_sio.c
> +++ b/drivers/usb/serial/ftdi_sio.c
> @@ -809,10 +809,10 @@ static const struct usb_device_id id_table_combined[] = {
> { USB_DEVICE(FTDI_VID, FTDI_PROPOX_ISPCABLEIII_PID) },
> { USB_DEVICE(FTDI_VID, CYBER_CORTEX_AV_PID),
> .driver_info = (kernel_ulong_t)&ftdi_jtag_quirk },
> - { USB_DEVICE(OLIMEX_VID, OLIMEX_ARM_USB_OCD_PID),
> - .driver_info = (kernel_ulong_t)&ftdi_jtag_quirk },
> - { USB_DEVICE(OLIMEX_VID, OLIMEX_ARM_USB_OCD_H_PID),
> - .driver_info = (kernel_ulong_t)&ftdi_jtag_quirk },
> + { USB_DEVICE_INTERFACE_NUMBER(OLIMEX_VID, OLIMEX_ARM_USB_OCD_PID, 1) },
> + { USB_DEVICE_INTERFACE_NUMBER(OLIMEX_VID, OLIMEX_ARM_USB_TINY_PID, 1) },
> + { USB_DEVICE_INTERFACE_NUMBER(OLIMEX_VID, OLIMEX_ARM_USB_TINY_H_PID, 1) },
> + { USB_DEVICE_INTERFACE_NUMBER(OLIMEX_VID, OLIMEX_ARM_USB_OCD_H_PID, 1) },
Now you're also replacing the jtag quirk for the current devices and
that would need to be mentioned in the commit message at least.
But since it's really a separate change, it should go in its own patch
and not necessarily be backported to stable (even if we may make things
harder for stable backporters this way).
I'll fix it up this time, but please keep the above notes in mind for
future submissions.
Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
