Hello, Any input on this topic? Kind Regards, Bogdan On Sun, 30 Apr 2017 03:22:10 Bogdan Mirea wrote: > Check for bad pointer that may result because of kthread_create failure. > This check is needed since the gserial setup callback function > (gs_console_setup()) is only freeing the info->con_buf in case of > kthread_create failure which will result into bad info->console_thread > pointer. > Without checking info->console_thread pointer validity in the > gserial_console_exit() function, before calling kthread_stop(), the > rmmod will generate Kernel Oops. > > Signed-off-by: Bogdan Mirea <bogdan-stefan_mi...@xxxxxxxxxx> > --- > drivers/usb/gadget/function/u_serial.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/function/u_serial.c > b/drivers/usb/gadget/function/u_serial.c > index 4be1e7e..0858f49 100644 > --- a/drivers/usb/gadget/function/u_serial.c > +++ b/drivers/usb/gadget/function/u_serial.c > @@ -1256,7 +1256,7 @@ static void gserial_console_exit(void) > struct gscons_info *info = &gscons_info; > > unregister_console(&gserial_cons); > - if (info->console_thread != NULL) > + if (!IS_ERR_OR_NULL(info->console_thread)) > kthread_stop(info->console_thread); > gs_buf_free(&info->con_buf); > } > -- > 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
