On Tue, Apr 18, 2017 at 4:36 AM, Ben Hutchings <ben@xxxxxxxxxxxxxxx> wrote:
> This reverts commit cb9c1cfc86926d0e86d19c8e34f6c23458cd3478 for
> USB_LED_TRIG. This config symbol has bool type and enables extra code
> in usb_common itself, not a separate driver. Enabling it should not
> force usb_common to be built-in!
>
> Fixes: cb9c1cfc8692 ("usb: Kconfig: using select for USB_COMMON dependency")
> Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> ---
> drivers/usb/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
> index fbe493d44e81..8270abe6c677 100644
> --- a/drivers/usb/Kconfig
> +++ b/drivers/usb/Kconfig
> @@ -154,8 +154,7 @@ source "drivers/usb/gadget/Kconfig"
>
> config USB_LED_TRIG
> bool "USB LED Triggers"
> - depends on LEDS_CLASS && LEDS_TRIGGERS
> - select USB_COMMON
> + depends on LEDS_CLASS && USB_COMMON && LEDS_TRIGGERS
> help
> This option adds LED triggers for USB host and/or gadget activity.
Maybe this should be 'depends on USB_SUPPORT' or
'depends on USB || USB_GADGET'?
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
