On Mon, 17 Apr 2017, Greg KH wrote: > On Mon, Apr 17, 2017 at 11:28:44AM +0200, Andreas Hartmann wrote: > > Hello! > > > > Since Linux 4.9, ums_eneub6250 is broken. It's working fine if > > CONFIG_VMAP_STACK is disabled. > > > > I would be glad if it would be fixed. > > Ah, nice catch, thanks for finding this. > > Does the patch below fix this for you? > > thanks, > > greg k-h > > --------------------- > > > diff --git a/drivers/usb/storage/ene_ub6250.c b/drivers/usb/storage/ene_ub6250.c > index 369f3c24815a..6a227b142146 100644 > --- a/drivers/usb/storage/ene_ub6250.c > +++ b/drivers/usb/storage/ene_ub6250.c > @@ -2180,21 +2180,29 @@ static int ene_sd_init(struct us_data *us) > @@ -2303,7 +2311,7 @@ static int ene_ub6250_probe(struct usb_interface *intf, Good start, but there are five (!) other places in this driver where the same bug occurs, at lines 904, 1350, 1577, 2088, and 2157. Would you like to fix them too? Maybe it would be easier for the driver to allocate a single 512-byte buffer at the start, and use it for all of these I/O requests. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
