On Mon, 2 Mar 2009, Thadeu Lima de Souza Cascardo wrote: > > Maybe there doesn't need to be a patch for this at all. Can't you get > > the same result by writing a udev rule? In fact, isn't that how the > > manage_start_stop flag is intended to be set? > > I did expect that doing it in user space would be the proper way. Any > tips on how to find out the USB id's given the disk? Look in /proc/bus/usb/devices or run lsusb. > > As for the patch itself... You are setting the flag in the wrong > > place. The manage_start_stop flag applies only to SCSI disk devices > > AFAICT. (The sysfs interface isn't present if the device isn't a disk, > > at any rate.) So you should set the flag in the code that applies to > > disks. > > I thought on adding a quirk flag to the SCSI host and, then, testing > that in the SCSI code itself. Didn't think SCSI guys would like that. Even if you keep the quirk in usb-storage, it should still go in the appropriate place, somewhat farther down than where you put it. > > Also, this patch won't apply to the current development tree, because > > there have been several changes to usb-storage's recently. In > > particular there is new code allowing quirk flags to be set by a module > > parameter, and your new flag (if it is accepted) should be added to > > this mechanism. > > Also expected. But I didn't know about the new changes in the quirk > flags code. Which tree should I refer to regarding usb-storage or USB, > besides next and rc trees? http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/ I tend to use the gregkh-all-*.patch files. However, I think everything in there also goes into -next. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
