Hi,
Minas Harutyunyan <Minas.Harutyunyan@xxxxxxxxxxxx> writes:
>> Minas Harutyunyan <Minas.Harutyunyan@xxxxxxxxxxxx> writes:
>>> After data out stage gadget driver should not initate ZLP on control EP,
>>> because it is up to function driver.
>>
>> not true always, depends on return value from ->setup(). Which problem
>> did you have? Which gadget driver? How did you reproduce? Which other
>> tests did you run on this patch?
>>
>
> This required for delayed status support. Tested with Synopsys test
> gadget. As host used USB tracer traffic generator (different control
> transfers scenarios). Also performed smoke tests with mass storage
> function to detect any side effects.
so you didn't test any gadget driver that doesn't rely on
delayed_status, right? Care to test one of those?
The situation here is a little too complex (and we're trying to change
it). Here's how it goes:
if (ctrl->wLength == 0) /* 2-stage ctrl */ {
gadget_driver always queues STATUS;
} else {
gadget_driver queues DATA;
if (result == DELAYED_STATUS)
gadgdet_driver queues STATUS
else
UDC handles STATUS
}
It seems to me, you're not handling this properly as of yet. Please make
sure several gadget drivers work for you. Try g_mass_storage and g_zero
at least. :-)
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
