Re: usb: host: xhci: stalled endpoint ring not cleared on empty td_list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 30 March 2017 at 11:23, Greg KH <greg@xxxxxxxxx> wrote:
> On Thu, Mar 30, 2017 at 11:11:34AM +0200, Janusz Dziedzic wrote:
>> On 30 March 2017 at 10:53, Greg KH <greg@xxxxxxxxx> wrote:
>> > On Thu, Mar 30, 2017 at 10:29:41AM +0200, Christian Gromm wrote:
>> >>
>> >>
>> >> On 03/27/2017 11:31 AM, Felipe Balbi wrote:
>> >> >
>> >> > Hi,
>> >> >
>> >> > Christian Gromm <christian.gromm@xxxxxxxxxxxxx> writes:
>> >> > > we observe an issue with a td_list running empty and an
>> >> > > endpoint being stalled at the same time on
>> >> > >
>> >> > > Linux ihu-low 4.1.27-abl #1 SMP PREEMPT Mon Mar 20 13:51:51 CET 2017
>> >> > > x86_64 x86_64 x86_64 GNU/Linux.
>> >> >
>> >> > this is one old kernel. Please upgrade to v4.11-rc4 or v4.10 and try again.
>> >> >
>> >>
>> >> Unfortunately, the system is Yocto based and cannot be updated to 4.10+.
>> >>
>> >> We applied the following patches to have the xhci code at 4.1.39
>> >>
>> >> $ git log --oneline v4.1.27..v4.1.39 -- drivers/usb/host/xhci-*
>> >> c068da4 xhci: fix deadlock at host remove by running watchdog correctly
>> >> 8e77b80 usb: xhci: apply XHCI_PME_STUCK_QUIRK to Intel Apollo Lake
>> >> 18ee106 usb: xhci: hold lock over xhci_abort_cmd_ring()
>> >> af7f5bf xhci: Handle command completion and timeout race
>> >> adae871 usb: host: xhci: Fix possible wild pointer when handling abort
>> >> command
>> >> 073dd4e usb: xhci: fix possible wild pointer
>> >> 4b6ac34 xhci: free xhci virtual devices with leaf nodes first
>> >> 605a696 xhci: workaround for hosts missing CAS bit
>> >> c23a6dc xhci: add restart quirk for Intel Wildcatpoint PCH
>> >> 3b244a6 xhci: fix usb2 resume timing and races.
>> >> 631f063 xhci: fix null pointer dereference in stop command timeout function
>> >> e1052fb usb: xhci: Fix panic if disconnect
>> >> 23c50b2 xhci: always handle "Command Ring Stopped" events
>> >> 95cb83b USB: xhci: Add broken streams quirk for Frescologic device id 1009
>> >> 0c3f25d usb: xhci-plat: properly handle probe deferral for devm_clk_get()
>> >> e78c8a5 xhci: Fix handling timeouted commands on hosts in weird states.
>> >>
>> >>
>> >> The issue is still there. Any other recommendation?
>> >
>> > Use a newer kernel, 4.1 is not supported at all.  If you are stuck with
>> > that kernel, go get support from the company that you are paying for
>> > support from for that kernel release.
>> >
>> Maybe we should start thinking about backporting USB stack -
>> https://backports.wiki.kernel.org.
>> In that case we could use newest USB stack with any older kernel.
>
> No, you can use a newer kernel please.  Backporting stuff is horrid,
> what is keeping you from just using a new kernel?  Nothing will break,
> unless you have out-of-tree patches (and if you do, that's your issue,
> not ours...)
>
I am lucky while I can work with current kernel. So this is not my problem :)

But, before I worked with android products (mostly 3.x kernels) where
kernel update was not an option and I always dream about USB backports
- instead of fixing old USB stack with a lot of hacks already
included. Maybe in the future someone will decide to backport also USB
stack ...

BR
Janusz

> thanks,
>
> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux