Re: [PATCH] cdc-wdm: add a dummy implementation of ioctls TCGETS and TCSETS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 27 Feb 2009 10:55:47 +0100
Bjørn Mork <bjorn@xxxxxxx> wrote:

> This patch adds a dummy implementation of the TCGETS and TCSETS ioctls
> to cdc-wdm.  This is necessary for userspace applications like "chat".

NAK. Either you implement all the functions *properly* including TCGETS2
and friends or you fix chat. The fact chat doesn't properly handle non tty
devices has been a complete pain in the butt for years when it could be
used on pipes and sockets.

Fix the real problem

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux