Am Freitag 27 Februar 2009 10:55:47 schrieb Bjørn Mork:
> This patch adds a dummy implementation of the TCGETS and TCSETS ioctls
> to cdc-wdm. This is necessary for userspace applications like "chat".
How common is that?
> Note: I have not understood why cdc-wdm isn't a fullblown TTY driver,
> like cdc-acm is. Could anyone care to explain?
The device is no tty. The operations specific to ttys make no sense.
Your patch essentially proves that implementing no-ops.
> The correct fix for the described problem may be changing cdc-wdm to use
> the TTY layer, but I guess that means renaming the devices and possibly
> other very userspace visible changes? Let me know if this is desired,
> and I'll try to provide a patch.
No, the correct fix is to fix "chat". The question is how practicable that
is.
> +static long wdm_ioctl(struct file *file, unsigned int cmd, unsigned long
> arg) +{
> + struct wdm_device *desc = file->private_data;
> +
> + if (!desc)
> + return -ENODEV;
Can't happen.
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
