Hi Greg, On Tue, 24 Feb 2009 22:04:48 -0800 Greg KH <greg@xxxxxxxxx> wrote: > On Mon, Feb 23, 2009 at 07:29:20PM +0100, Karsten Wiese wrote: > > > > ehci-hcd uses usb_get_urb() and usb_put_urb() in an unbalanced way causing > > isochronous URB's kref.counts incrementing once per usb_submit_urb() call. > > There is no need for ehci-hcd to deal with usb_get_urb() nor usb_put_urb() > > anyhow, so patch removes their usages in ehci-hcd. > > It also removes NULL assignments that have no effect. > > > > Signed-off-by: Karsten Wiese <fzu@xxxxxxxxxxxxxxxxxxxxx> > > --- > > > > Made against 2.6.29-rc6. Suitable to go there and stable ASAP, no? > > Are you sure this is still needed? This patch is needed. It fixes a bug with USB v4l/dvb drivers, where memory leaks are sometimes generated when calling usb_kill_urb(). By using this patch against 2.6.29-rc-git2, it fixed the issue. I suspect that this patch should also be backported to -stable. Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
