Re: [PATCH] e-mail address change in drivers/usb/storage/unusual_devs.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 8 Mar 2017, Phillip Potter wrote:

> Dear all,
> 
> Just submitting a very minor patch to update my e-mail address in this file - I sent
> a patch years ago to update the listed firmware version to make newer versions of the
> Nokia 6288 mountable as mass storage devices. I hope my patch is in the right format,
> I've tried to pay attention to the docs - sorry if not. Thanks.
> 
> Regards,
> Phil Potter

The format isn't quite right.  Remember, whatever you put at the start
of the email will be part of the permanent log, so it shouldn't be in
the form of a normal mail message -- it should be in the form of a
Changelog entry.  Look at some of the other patch submissions in the
mailing list archives to get an idea.

> 
> Signed-off-by: Phillip Potter <phil@xxxxxxxxxxxxxxxx>

There needs to be a line containing nothing but --- here, to separate 
the ChangeLog entry from the patch itself.

For more details, see Documentation/submitting-patches.txt.  Also, 
patches for the usb-storage driver should be CC'ed to Greg KH 
<gregkh@xxxxxxxxxxxxxxxxxxx>.

Alan Stern

> --- a/drivers/usb/storage/unusual_devs.h        2017-03-07 18:05:22.674952200 +0000
> +++ b/drivers/usb/storage/unusual_devs.h        2017-03-07 18:17:26.374170000 +0000
> @@ -176,7 +176,7 @@ UNUSUAL_DEV(  0x0420, 0x0001, 0x0100, 0x
> 
>   /*
>    * Reported by Andrew Nayenko <relan@xxxxx>
> - * Updated for new firmware by Phillip Potter <phillipinda@xxxxxxxxxxx>
> + * Updated for new firmware by Phillip Potter <phil@xxxxxxxxxxxxxxxx>
>    */
>   UNUSUAL_DEV(  0x0421, 0x0019, 0x0592, 0x0610,
>                  "Nokia",
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux