Re: [PATCH v2] usb: dwc2: pci: Fix error handling in dwc2_pci_probe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Vardan Mikayelyan <Vardan.Mikayelyan@xxxxxxxxxxxx> writes:
> Move usb_phy_generic_register() function call to the top, to simplify
> error handling.
>
> Replace kzalloc() with devm_kzalloc().
>
> After platform_device_add(), if we error out, we must do
> platform_device_unregister(), which also does the put. So lets move
> devm_kzalloc() to simplify error handling and avoid
> calling of platform_device_unregister().
>
> Reviewed-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> Signed-off-by: Vardan Mikayelyan <mvardan@xxxxxxxxxxxx>

this patch does more than one thing. I can't apply like that, sorry. I
can see three unrelated changes going on here, please split the patch
and resend.

-- 
balbi

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux