Hi Roger, On Wednesday 01 Mar 2017 17:09:51 Roger Quadros wrote: > Hi, > > I'm no longer able to use g_webcam with uvc-gadget [1] since v4.9. Logs at > the end. It looks like we're goofing up on the control endpoint. > > If I revert the following commit everything works fine. > commit 4fbac5206afd01b717d4bdc58793d471f3391b4b > Author: Petr Cvek <petr.cvek@xxxxxx> > Date: Wed Aug 17 12:36:57 2016 +0200 > > usb: gadget: uvc: Add missing call for additional setup data > > Am I missing something on uvc-gadget side or is the commit really bad? > From what I understand, uvc-gadget is responsible for sending response to > UVC class specific requests on control endpoint in uvc_send_response() > in uvc_v4l2.c. > > So the reported commit is sending a duplicate response with probably > improper data. Yes, this looks very dubious to me. I think it should be reverted. My apologies for not having caught the patch during review. Would you like to send a revert patch ? > [1] - git://git.ideasonboard.org/uvc-gadget.git -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
