On Fri, Feb 20, 2009 at 02:22:42PM -0800, David Brownell wrote: > On Friday 20 February 2009, Felipe Balbi wrote: > > On Fri, Feb 20, 2009 at 02:07:58PM -0800, David Brownell wrote: > > > On Friday 20 February 2009, Felipe Balbi wrote: > > > > On Fri, Feb 20, 2009 at 01:45:17PM -0800, David Brownell wrote: > > > > > @@ -116,7 +116,7 @@ > > > > > > > > > > unsigned musb_debug; > > > > > module_param(musb_debug, uint, S_IRUGO | S_IWUSR); > > > > > -MODULE_PARM_DESC(debug, "Debug message level. Default = 0"); > > > > > +MODULE_PARM_DESC(musb_debug, "Debug message level. Default = 0"); > > > > > > > > we could actually use module_param_named(debug, musb_debug, ....); > > > > > > I was just making the existing interface work right, > > > not trying to change anything. > > > > Yeah sure, that was more like a note than a comment to the patch itself > > ;-) > > > > Anyways, here's the patch changing to module_param_named() on top of > > this one: > > > > ========== cut here ========== > > >From 85e17a9284734ce281bda3407a0286caf323f5db Mon Sep 17 00:00:00 2001 > > From: Felipe Balbi <me@xxxxxxxxxxxxxxx> > > Date: Sat, 21 Feb 2009 00:12:14 +0200 > > Subject: [PATCH] usb: musb: use module_param_named > > > > Change modprobe musb_hdrc musb_debug=3 to > > modprobe musb_hdrc debug=3. > > > > Signed-off-by: Felipe Balbi <me@xxxxxxxxxxxxxxx> > > OK by me, even if Greg wants to merge this with the $SUBJECT patch. I've now done so, thanks. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
