On Tue, 28 Feb 2017, Pierre-Yves Kerbrat wrote:
> Remove the useless variable 'partial' storing the actual length
> transferred. Nothing was done with it, so simply get rid of it
> as usb_stor_bulk_transfer_buf can handle having NULL instead.
>
> This also fixes the following sparse issues (-Wtypesign):
> drivers/usb/storage/karma.c:122:51: warning: incorrect type in argument
> 5 (different signedness)
> drivers/usb/storage/karma.c:122:51: expected unsigned int *act_len
> drivers/usb/storage/karma.c:122:51: got int *<noident>
> drivers/usb/storage/karma.c:127:52: warning: incorrect type in argument
> 5 (different signedness)
> drivers/usb/storage/karma.c:127:52: expected unsigned int *act_len
> drivers/usb/storage/karma.c:127:52: got int *<noident>
>
> Signed-off-by: Pierre-Yves Kerbrat <pkerbrat@xxxxxxx>
> ---
> drivers/usb/storage/karma.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/storage/karma.c b/drivers/usb/storage/karma.c
> index f9d407f0b508..b05ba4929f00 100644
> --- a/drivers/usb/storage/karma.c
> +++ b/drivers/usb/storage/karma.c
> @@ -105,7 +105,7 @@ static struct us_unusual_dev karma_unusual_dev_list[] = {
> */
> static int rio_karma_send_command(char cmd, struct us_data *us)
> {
> - int result, partial;
> + int result;
> unsigned long timeout;
> static unsigned char seq = 1;
> struct karma_data *data = (struct karma_data *) us->extra;
> @@ -119,12 +119,12 @@ static int rio_karma_send_command(char cmd, struct us_data *us)
> timeout = jiffies + msecs_to_jiffies(6000);
> for (;;) {
> result = usb_stor_bulk_transfer_buf(us, us->send_bulk_pipe,
> - us->iobuf, RIO_SEND_LEN, &partial);
> + us->iobuf, RIO_SEND_LEN, NULL);
> if (result != USB_STOR_XFER_GOOD)
> goto err;
>
> result = usb_stor_bulk_transfer_buf(us, us->recv_bulk_pipe,
> - data->recv, RIO_RECV_LEN, &partial);
> + data->recv, RIO_RECV_LEN, NULL);
> if (result != USB_STOR_XFER_GOOD)
> goto err;
Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
