On 2/22/2017 10:59 PM, John Youn wrote: > On 2/21/2017 5:16 AM, David Laight wrote: >> From: Vardan Mikayelyan >>> Sent: 20 February 2017 15:15 >>> dwc2_clear_force_mode() can be called in hibernation exit flow which >>> can occur in interrupt context. >>> >>> Signed-off-by: Vardan Mikayelyan <mvardan@xxxxxxxxxxxx> >>> --- >>> drivers/usb/dwc2/core.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c >>> index 2c90d8e..c7c76e8 100644 >>> --- a/drivers/usb/dwc2/core.c >>> +++ b/drivers/usb/dwc2/core.c >>> @@ -634,7 +634,7 @@ void dwc2_clear_force_mode(struct dwc2_hsotg *hsotg) >>> dwc2_writel(gusbcfg, hsotg->regs + GUSBCFG); >>> >>> if (dwc2_iddig_filter_enabled(hsotg)) >>> - msleep(100); >>> + mdelay(100); >> >> Spinning for 100ms isn't good at all. >> > > Agreed. > > Vardan, I thought you had a change that avoided this issue entirely? > > Thanks, > John > John, David thank you for review. Yeah actually that was fixed by "usb: dwc2: Force mode optimizations" which is now in the "next". So we can exclude last patch from this series. Thanks, Vardan. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
