On Mon, Feb 20, 2017 at 05:28:46PM -0600, Gustavo A. R. Silva wrote: > 'val' is an unsigned variable, and less-than-zero comparison of an unsigned > variable is never true. I would add that val is set by kstrtoul() that converts a string to an unsigned long. > > Addresses-Coverity-ID: 1230257 Reviewed-by: Peter Senna Tschudin <peter.senna@xxxxxxxxx> > Signed-off-by: Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx> > --- > drivers/usb/misc/lvstest.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/misc/lvstest.c b/drivers/usb/misc/lvstest.c > index c7c2104..6f37610 100644 > --- a/drivers/usb/misc/lvstest.c > +++ b/drivers/usb/misc/lvstest.c > @@ -193,7 +193,7 @@ static ssize_t u2_timeout_store(struct device *dev, > return ret; > } > > - if (val < 0 || val > 127) > + if (val > 127) > return -EINVAL; > > ret = lvs_rh_set_port_feature(hdev, lvs->portnum | (val << 8), > -- > 2.5.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
