On Thu, 16 Feb 2017 14:54:12 +0100, Janusz Dziedzic
<januszx.dziedzic@xxxxxxxxxxxxxxx> wrote:
> This reverts commit ac670a3a650b899fc020b81f63e810d06015b865.
>
> This introduce bug we already fixed in
> commit 53642399aa71 ("usb: gadget: f_fs: Fix wrong check on reserved1 wof OS_DESC_EXT_COMPAT")
>
> Next FFS (adb) SS enumeration fail with Windows OS.
Sorry for the regression.
The the functionfs header documentation needs fixing then:
include/uapi/linux/usb/functionfs.h
* ExtCompat[] is an array of valid Extended Compatiblity descriptors
* which have the following format:
*
* | off | name | type | description |
* |-----+-----------------------+------+-------------------------------------|
* | 0 | bFirstInterfaceNumber | U8 | index of the interface or of the 1st|
* | | | | interface in an IAD group |
* | 1 | Reserved | U8 | 0 | <- here
* | 2 | CompatibleID | U8[8]| compatible ID string |
* | 10 | SubCompatibleID | U8[8]| subcompatible ID string |
* | 18 | Reserved | U8[6]| 0 |
Regards,
--
Vincent Pelletier
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
