Re: [usb-storage] usb: storage: suspicious code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Oliver,

Quoting Oliver Neukum <oneukum@xxxxxxxx>:

Am Dienstag, den 14.02.2017, 23:06 -0600 schrieb Gustavo A. R. Silva:

Hi,

waitcount = 0;
do {
        result = jumpshot_get_status(us);
        if (result != USB_STOR_TRANSPORT_GOOD) {
                // I have not experimented to find the smallest
value.
                //
                msleep(50);
        }
        } while ((result != USB_STOR_TRANSPORT_GOOD) && (waitcount <
10));

        if (result != USB_STOR_TRANSPORT_GOOD)
                usb_stor_dbg(us, "Gah!  Waitcount = 10.  Bad
write!?\n");

Variable 'waitcount' is never updated inside the do-while loop. So,
either it isn't needed at all or line 316 should be modified
(++waitcount < 10)

you are correct. Waitcount needs to be incremented.


Thanks for clarifying, I'll send a patch shortly.

--
Gustavo A. R. Silva




--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux