On Tue, Feb 14, 2017 at 08:46:16PM +0800, yuan linyu wrote: > From: yuan linyu <Linyu.Yuan@xxxxxxxxxxxxxxxxxxxx> > > one usage is in embedded system usb host controller is non-PCI based, > chooe N in such system will not compile PCI code/function of USB. I'm really sorry, but I can not parse this very well. What exact problem does this patch solve? Why is it needed? It seems to just keep the same functionality that we currently have today, right? We already distinguish PCI/non-PCI based USB host controllers by using the CONFIG_PCI option, why do we need to add another one? > > Signed-off-by: yuan linyu <Linyu.Yuan@xxxxxxxxxxxxxxxxxxxx> > --- > drivers/usb/Kconfig | 9 ++++++++- > drivers/usb/Makefile | 2 +- > drivers/usb/chipidea/Kconfig | 2 +- > drivers/usb/core/Makefile | 2 +- > drivers/usb/dwc2/Kconfig | 2 +- > drivers/usb/dwc3/Kconfig | 2 +- > drivers/usb/gadget/udc/Kconfig | 8 ++++---- > drivers/usb/gadget/udc/bdc/Kconfig | 2 +- > drivers/usb/gadget/udc/net2272.c | 8 ++++---- > drivers/usb/gadget/udc/net2272.h | 2 +- > drivers/usb/host/Kconfig | 10 +++++----- > drivers/usb/host/ehci-dbg.c | 2 +- > drivers/usb/host/ohci-hcd.c | 2 +- > drivers/usb/host/ohci.h | 2 +- > drivers/usb/host/pci-quirks.h | 4 ++-- > drivers/usb/host/uhci-hcd.c | 2 +- > drivers/usb/host/uhci-hcd.h | 2 +- > drivers/usb/host/xhci.c | 2 +- > drivers/usb/isp1760/isp1760-if.c | 8 ++++---- > include/linux/usb/hcd.h | 4 ++-- > 20 files changed, 42 insertions(+), 35 deletions(-) > > diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig > index fbe493d..d6558f2 100644 > --- a/drivers/usb/Kconfig > +++ b/drivers/usb/Kconfig > @@ -35,7 +35,6 @@ config USB_COMMON > config USB_ARCH_HAS_HCD > def_bool y > > -# ARM SA1111 chips have a non-PCI based "OHCI-compatible" USB host interface. > config USB > tristate "Support for Host-side USB" > depends on USB_ARCH_HAS_HCD > @@ -73,6 +72,14 @@ config USB > To compile this driver as a module, choose M here: the > module will be called usbcore. > > +config USB_PCI > + bool "PCI based USB host interface" > + depends on PCI > + default y > + ---help--- > + if system have both PCI and USB, but USB is non-PCI related, > + say N here allow PCI related code not compiled. Again, I think this needs some more description, as I do not understand why this new option is needed at all. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
