On Thu, Feb 09, 2017 at 05:40:50PM +0530, Vivek Gautam wrote: > On Thu, Feb 9, 2017 at 5:24 PM, Roger Quadros <rogerq@xxxxxx> wrote: > > > > > > On 09/02/17 13:53, Roger Quadros wrote: > >> > >> > >> On 08/02/17 22:43, Jack Pham wrote: > >>> Hi Peter, Sriram, Arnd, > >>> > >>> On Mon, Feb 06, 2017 at 05:13:38PM +0800, Peter Chen wrote: > >>>> From: Arnd Bergmann <arnd@xxxxxxxx> > >>>> > >>>> For xhci-hcd platform device, all the DMA parameters are not > >>>> configured properly, notably dma ops for dwc3 devices. So, set > >>>> the dma for xhci from sysdev. sysdev is pointing to device that > >>>> is known to the system firmware or hardware. > >>>> > >>>> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > >>>> Signed-off-by: Sriram Dash <sriram.dash@xxxxxxx> > >>>> Tested-by: Baolin Wang <baolin.wang@xxxxxxxxxx> > >>>> Tested-by: Vivek Gautam <vivek.gautam@xxxxxxxxxxxxxx> > >>>> Tested-by: Alexander Sverdlin <alexander.sverdlin@xxxxxxxxx> > >>>> Signed-off-by: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx> > >>>> --- > >>>> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c > >>>> index 6d33b42..7a9c860 100644 > >>>> --- a/drivers/usb/host/xhci-plat.c > >>>> +++ b/drivers/usb/host/xhci-plat.c > >>> > >>>> - hcd = usb_create_hcd(driver, &pdev->dev, dev_name(&pdev->dev)); > >>>> + hcd = __usb_create_hcd(driver, sysdev, &pdev->dev, > >>>> + dev_name(&pdev->dev), NULL); > >>> > >>> As mentioned already in [1], usb_create_shared_hcd() is called to create > >>> the second bus, however it also needs to be converted. > >>> > >>> Not exactly as Roger's suggestion but this worked for me: > >>> > >>> - xhci->shared_hcd = usb_create_shared_hcd(driver, &pdev->dev, > >>> + xhci->shared_hcd = __usb_create_hcd(driver, sysdev, &pdev->dev, > >>> dev_name(&pdev->dev), hcd); > >> > >> But we're creating a shared_hcd and there is an API for that so why not use it > >> instead of calling __usb_create_hcd()? > >> > > > > Just realized after I pressed send that there is no sysdev parameter > > for create_shared_hcd(). Roger, does this change also work for you? If it is, please add a tested-by tag for my v13 patch set. -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
