On Wed, 2017-02-08 at 21:03 +0100, Richard Leitner wrote: > On 02/08/2017 08:20 PM, Andy Shevchenko wrote: > > On Wed, 2017-02-08 at 19:45 +0100, Richard Leitner wrote: > > > On 02/08/2017 05:40 PM, Andy Shevchenko wrote: > > > > On Wed, 2017-02-08 at 16:17 +0100, Richard Leitner wrote: > > > > > On 02/08/2017 02:59 PM, Greg KH wrote: > > > > > > > Should I keep my inline {clr,set}_bit_in_byte() > functions an use BIT() in there, or delete them and use BIT() > directly > in usb251xb_get_ofdata() ? Does it make any sense? Even just name of your function is longer than what it substitutes. -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html