On Wed, 8 Feb 2017, Peter Chen wrote: > >> On Thu, Jan 19, 2017 at 02:21:26PM +0200, Mathias Nyman wrote: > >> > Hi Greg > >> > > >> > This series by Arnd Bergmann was originally six patches, but last > >> > two of them were already taken to 4.10. Without the rest of them > >> > there will be a regression in 4.10. > >> > > >> > Original cover letter says: > >> > > >> > For xhci-hcd platform device, all the DMA parameters are not > >> > configured properly, notably dma ops for dwc3 devices. > >> > > >> > The idea here is that you pass in the parent of_node along with the > >> > child device pointer, so it would behave exactly like the parent > >> > already does. The difference is that it also handles all the other > >> > attributes besides the mask. > >> > > >> > -Mathias > >> > > >> > Arnd Bergmann (4): > >> > usb: separate out sysdev pointer from usb_bus > >> > usb: chipidea: use bus->sysdev for DMA configuration > >> > usb: ehci: fsl: use bus->sysdev for DMA configuration > >> > usb: xhci: use bus->sysdev for DMA configuration > >> > >> The ehci part needs to similar change, otherwise, it will fail too. > >> I post a patch for it [1]. Alan, would you please help to review it? > >> Then, Greg can pick up the five patches together. > >> > >> [1] http://www.spinics.net/lists/linux-usb/msg153263.html > > > >That patch contains a lot of unrelated whitespace changes. Can you redo it with only > >the necessary changes? > > > > Alan, the ./scripts/checkpatch.pl complaints it, so I made changes, and I think the > whitespace changes are not needed to have an additional patch, so I add these whitespace > changes to this patch, is it ok I just add the comments to mention that? > > Below is console output for the patch without whitespace changes: > > b29397@b29397-desktop:~/work/projects/usb$ ./scripts/checkpatch.pl 0001-usb-ehci-use-bus-sysdev-for-DMA-configuration.patch > WARNING: space prohibited between function name and open parenthesis '(' > #25: FILE: drivers/usb/host/ehci-mem.c:141: > + dma_free_coherent (ehci_to_hcd(ehci)->self.sysdev, > > WARNING: space prohibited between function name and open parenthesis '(' > #70: FILE: drivers/usb/host/ehci-mem.c:202: > + dma_alloc_coherent (ehci_to_hcd(ehci)->self.sysdev, > > total: 0 errors, 2 warnings, 48 lines checked > > NOTE: For some of the reported defects, checkpatch may be able to > mechanically convert to the typical style using --fix or --fix-inplace. > > 0001-usb-ehci-use-bus-sysdev-for-DMA-configuration.patch has style problems, please review. It's okay to fix the whitespace in those two lines, because you're changing them anyway. But don't change any other lines just to make them look better. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
