On Tue, 7 Feb 2017, Jelle Martijn Kok wrote: > I actually stumbled on the next (quite unimportant) typo. > > In "ohci-hub.c" there is "dbg_port" macro which uses the "outside" > parameter (="temp") instead of the parameters (="value") given in the macro. > > This actually poses no problem as it is a macro and not a function. > > Below is the diff. This is a valid correction. Please resubmit it, following the procedure described in Documentation/SubmittingPatches, and be sure to CC: Greg KH <greg@xxxxxxxxx> and the USB list <linux-usb@xxxxxxxxxxxxxxx>. You can add Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> to the submission. Alan Stern > Best Regards, > > Jelle Martijn Kok > > $ git diff drivers/usb/host/ohci-hub.c > diff --git a/drivers/usb/host/ohci-hub.c b/drivers/usb/host/ohci-hub.c > index ed678c17..248eb77 100644 > --- a/drivers/usb/host/ohci-hub.c > +++ b/drivers/usb/host/ohci-hub.c > @@ -17,21 +17,21 @@ > ohci_dbg (hc, \ > "%s roothub.portstatus [%d] " \ > "= 0x%08x%s%s%s%s%s%s%s%s%s%s%s%s\n", \ > - label, num, temp, \ > - (temp & RH_PS_PRSC) ? " PRSC" : "", \ > - (temp & RH_PS_OCIC) ? " OCIC" : "", \ > - (temp & RH_PS_PSSC) ? " PSSC" : "", \ > - (temp & RH_PS_PESC) ? " PESC" : "", \ > - (temp & RH_PS_CSC) ? " CSC" : "", \ > + label, num, value, \ > + (value & RH_PS_PRSC) ? " PRSC" : "", \ > + (value & RH_PS_OCIC) ? " OCIC" : "", \ > + (value & RH_PS_PSSC) ? " PSSC" : "", \ > + (value & RH_PS_PESC) ? " PESC" : "", \ > + (value & RH_PS_CSC) ? " CSC" : "", \ > \ > - (temp & RH_PS_LSDA) ? " LSDA" : "", \ > - (temp & RH_PS_PPS) ? " PPS" : "", \ > - (temp & RH_PS_PRS) ? " PRS" : "", \ > - (temp & RH_PS_POCI) ? " POCI" : "", \ > - (temp & RH_PS_PSS) ? " PSS" : "", \ > + (value & RH_PS_LSDA) ? " LSDA" : "", \ > + (value & RH_PS_PPS) ? " PPS" : "", \ > + (value & RH_PS_PRS) ? " PRS" : "", \ > + (value & RH_PS_POCI) ? " POCI" : "", \ > + (value & RH_PS_PSS) ? " PSS" : "", \ > \ > - (temp & RH_PS_PES) ? " PES" : "", \ > - (temp & RH_PS_CCS) ? " CCS" : "" \ > + (value & RH_PS_PES) ? " PES" : "", \ > + (value & RH_PS_CCS) ? " CCS" : "" \ > ); > > /*-------------------------------------------------------------------------*/ > > > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
