On Thursday 19 February 2009, Qiuping Chen wrote:
> Add support for OID OID_802_3_MAXIMUM_LIST_SIZE and
> OID_802_3_MAC_OPTIONS in gen_ndis_query_resp() of rndis.c to make
> RNDIS gadget pass 1c_SetMulticast subtest in Microsoft NDISTest6.
There are tests for RNDIS drivers to pass? Will wonders
never cease!
How does one get these tests? And are there other issues
they turn up with this driver?
>
> Signed-off-by: Helen Chen <helen.chen@xxxxxxxxx>
>
> ---
> drivers/usb/gadget/rndis.c | 4 +-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/gadget/rndis.c b/drivers/usb/gadget/rndis.c
> index 8c26f5e..67fb17c 100644
> --- a/drivers/usb/gadget/rndis.c
> +++ b/drivers/usb/gadget/rndis.c
> @@ -439,12 +439,14 @@ gen_ndis_query_resp (int configNr, u32 OID, u8
> *buf, unsigned buf_len,
> case OID_802_3_MAXIMUM_LIST_SIZE:
> pr_debug("%s: OID_802_3_MAXIMUM_LIST_SIZE\n", __func__);
> /* Multicast base address only */
> - *outbuf = __constant_cpu_to_le32 (1);
> + *outbuf = __constant_cpu_to_le32(32);
Can you change this to just use cpu_to_le32()? That's
now fixed to handle constant folding correctly. Same
thing below.
> retval = 0;
> break;
>
> case OID_802_3_MAC_OPTIONS:
> pr_debug("%s: OID_802_3_MAC_OPTIONS\n", __func__);
> + *outbuf = __constant_cpu_to_le32(0);
> + retval = 0;
> break;
> break;
>
> /* ieee802.3 statistics OIDs (table 4-4) */
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
