On Mon, 06 Feb 2017 12:04:29 +0100, Andrej Kruták wrote: > > On Mon, Feb 6, 2017 at 12:01 PM, Takashi Iwai <tiwai@xxxxxxx> wrote: > > On Mon, 06 Feb 2017 11:18:44 +0100, > > Greg KH wrote: > >> > >> On Mon, Feb 06, 2017 at 01:01:56PM +0300, Igor Zinovev wrote: > >> > Hello again! > >> > > >> > Thanks for the advice, but bisecting the whole tree took me quite a > >> > while and I ended up stuck because booting on some bisect states has > >> > led my system to run without some devices, like wireless and sound. So > >> > I tried to bisect the sound/usb/line6 path. It turns out that this > >> > commit is the point where it breaks for me: > >> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/sound/usb/line6?id=f6a0dd107ad0c8b59d1c9735eea4b8cb9f460949 > >> > > >> > In fact, when I apply the reverse patch on top of 4.10-rc7, it fixes > >> > the problem for me. > >> > >> Wonderful, thanks so much for tracking this down! > >> > >> > Should I bring some of the people that are mentioned in the commit > >> > into this conversation? > >> > >> I've done so now. Andrej and Takashi, the above patch causes a > >> regression for Igor, any thoughts? Should we just revert it? > > > > Yeah, the patch looks wrong, the function line6_get_interval() should > > be called unconditionally. > > > > I'm going to queue a revert for 4.10-final. > > > > Yep, on the first look it's suspicious. I'll have a look on it in the > evening - not sure simple revert is the ideal solution... I'll get > back to you. I guess in this case the revert is the best option. But I'll postpone it until tomorrow. If you find a better solution, please let me know. > PS: Thanks for the bisecting, Igor! > PPS: Maybe this should go also to 4.9 stable, once resolved... Yes, definitely. thanks, Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
