Re: [PATCH 3/3] MUSB : Fix for STALL handling in musb gadget code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Swami,

I'm scanning mail queues for MUSB patches that may need
merging.  I think this thread didn't have such a patch,
but it did raise some issues that don't yet seem to have
been resolved.

That said, stall handling has always been a PITA -- only
used by USB mass storage class, and conformance tests,
which have somewhat conflicting requirements -- so this
particular flamefest was no real surprise.


On Sunday 07 December 2008, Subbrathnam, Swaminathan wrote:
> While working on DaVinci and other platforms that are
> utilizing the Mentor controller and the Linux MUSB stack
> we faced the following issues.  
> 
> 1. In-correct cancellation of CSW request in the context of
> the associated EP being stalled.  This is leading to the USB
> device being reset.  This happens in the context of MSC gadget.  

Is this still an issue in the current GIT kernel?

(I know that this once worked correctly, FWIW, and I'm not
sure where the bug would have come from.  Bitrot or the like,
presumably.)


> 2. When WHQL tests are run against a RNDIS-CDC gadget the Halt
> Endpoint tests fail on a BULK IN EP. This is due to the fact
> that that BULK-In EP had in-flight IO's and the original gadget
> driver was returning failure status to the Halt Endpoint request
> coming from the host (FIFO being full).    

It would be nice if those were USB-IF tests not Microsoft
ones, so they were more accessible.  And so the notion of
Microsoft creating their own variant of the USB standards
weren't so up-front-and-obnoxious.  :(

Is this also still an issue?   This sounds not-quite-like
the standard USBCV test.  Which I think I need to run again.


Alan's comments on this seemed, unsurprisingly, to be the
most on-the mark.

- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux