On 2017-02-01 01:02, Felipe Balbi wrote: > Hi, > > Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> writes: >> On Tue, Jan 31, 2017 at 06:19:17PM -0800, Stefan Agner wrote: >>> Other unsigned properties return hexadecimal values, follow this >>> convention when printing b_vendor_code too. Also add newlines to >>> the OS Descriptor support related properties, like other sysfs >>> files use. >> >> configfs is not sysfs, so watch out, you might not need/want those new >> lines as tools read the values and are not expecting them. >> >> Have you verified that nothing will break with this? How have you >> tested it? I am actually writing OS Descriptor support for libusbgx (fork of libusbg) when I stumbled upon this. The helper function there do not care about the new line, but I just thought we should fix it for the sake of coherency to the other properties. I am also fine dropping this patch. > > I would rather not change things like that, specially since Android guys > are alreadying using configfs. Do you happen to know where the source of that part is? So we could check if they make use of any OS Descriptor support yet... -- Stefan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
