Hi Johan,
> You made some further changes than what I suggested but forgot to
> document those. Often better to explicitly list the changes made rather
> than refer to review comments this way.
Sorry for that, I'll try to describe changes more verbosely.
> > + if (res < 0)
> > + return res;
> > +
> > + if (res != size) {
> > + dev_err(dev, "%s - send failed: opcode=%02x, size=%d, res=%d\n",
> > + __func__, *(u8 *)data, size, res);
>
> You still want an error message in case res < 0 (as in v3), but you can
> return that errno instead of -EIO then.
>
> You can drop the __func__ prefixes you added to error messages in v5
> throughout, better to spell out what went wrong (e.g. "failed to send
> control request %02x: %d\n", *(u8 *)data, res).
Thanks.
>
> This is new in v5, and should have been mentioned in the changelog above.
>
> Note that this is not strictly necessary, though. Some drivers
> dereferenced pointers without the appropriate sanity checks, but this
> driver and the generic callbacks it uses, does not suffer from such
> problems.
>
> I suggest you just drop this check (i.e. the attach callback).
Ok. I saw a bunch of patches in the list that added such check to almost
every driver, so I suspected such check is required in this one too.
Thanks,
Maksim.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
