From: Mathias Nyman
> Sent: 20 January 2017 14:47
> From: Felipe Balbi <felipe.balbi@xxxxxxxxxxxxxxx>
>
> If we add that newline, the output will like like the following:
>
> kworker/2:1-42 [002] .... 169.811435: xhci_address_ctx:
> ctx_64=0, ctx_type=2, ctx_dma=@153fbd000, ctx_va=@ffff880153fbd000
>
> We would rather have that in a single line.
...
> diff --git a/drivers/usb/host/xhci-trace.h b/drivers/usb/host/xhci-trace.h
> index 4bad0d6..08bed2f 100644
> --- a/drivers/usb/host/xhci-trace.h
> +++ b/drivers/usb/host/xhci-trace.h
> @@ -103,7 +103,7 @@
> ((HCC_64BYTE_CONTEXT(xhci->hcc_params) + 1) * 32) *
> ((ctx->type == XHCI_CTX_TYPE_INPUT) + ep_num + 1));
> ),
> - TP_printk("\nctx_64=%d, ctx_type=%u, ctx_dma=@%llx, ctx_va=@%p",
> + TP_printk("ctx_64=%d, ctx_type=%u, ctx_dma=@%llx, ctx_va=@%p",
> __entry->ctx_64, __entry->ctx_type,
> (unsigned long long) __entry->ctx_dma, __entry->ctx_va
I suspect the '\n' needs to go at the end of the previous trace?
Attempts to generate single lines from multiple printk() calls
are doomed to give unreadable output.
As are attempts to generate readable multi-line output.
(Ever had multiple cpus splat stack traces at the same time??)
David
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
