On 23.01.2017 13:57, David Laight wrote:
From: Mathias Nyman
Sent: 20 January 2017 14:47
Instead of storing a zero length array of td pointers, and then
allocate memory both for the td pointer array and the td's, just
use a zero length array of actual td's in urb private data.
This reminds me of an old patch that got reverted because things
broke because the lifetimes/accesses of the data wasn't the obvious one.
Can you recall more details about that case? I'd hate to revert this
later.
I looked at the history how we ended up with this type of allocation for
urb priv. I couldn't find any reverts or reasons why it's the way it is.
That might have been a different structure.
FWIW it is a shame that things like USB3 ethernet can't transmit and
receive without all these intermediate and dynamically allocated
structures.
Well, there's one less allocation after this patch :)
-Mathias
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
