On 23.01.2017 10:12, Mathias Nyman wrote:
On 20.01.2017 20:18, Felipe Balbi wrote:
Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx> writes:
Remove duplicate code by using trb_to_noop() when
handling Aborted commads
Signed-off-by: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>
isn't this just [1] ????
https://marc.info/?i=20161229110109.26372-25-felipe.balbi@xxxxxxxxxxxxxxx
A simplified version of [1].
There are only two types of no-op trbs, command and transfer no-ops.
We always know to which one of these we want to turn the trb so just
give it as a parameter.
Solution [1] takes any trb and turns it into no-op, it's a more generic
solution but it comes with the expense of code complexity, like the 20-case
switch statement to check trb type to narrow it down to two options.
I want xhci code to be as simple as possible.
I'm resending the series anyway to fix the extra empty lines and a typo,
want me to add a Suggested-by, or a "based on code by comment" to patch 25 and 26?
-Mathias
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
