On Wed, 2/18/09, Oliver Neukum <oliver@xxxxxxxxxx> wrote:
> A separate quirk type for this makes no sense.
The cdc-acm driver uses CDC descriptors to populate country code information in /sys and for a few other small branches that I do not fully understand. My proposed quirk would bring these minor benefits to users of devices with the defect of the CDC descriptors being on the "data" interface instead of the "communications" interface, a defect which apparently is common enough to have already been accommodated in the lsusb program. I would not be surprised if the two other Conexant modems currently listed with NO_UNION_NORMAL quirk really just have this milder defect as well as the Zoom 3095f (since its USB ID is listed at http://www.linuxant.com/drivers/dgc/index.php as using a Conexant chip, so perhaps might have related firmware genealogy).
I am not saying that I know that such a quirk would definitely be worth the implementation effort to anyone who might be motivated, but I am saying that your remark does not provide sufficient information for me to understand or agree that the idea of such a quirk definitely "makes no sense."
That said, feel free to trim my comment in the patch if you wish.
> The patch is good, but you need to add a "Signed-off-by" line.
OK. Here it is again with the a signed-off-by line at the end of my explanation.
Thank you for your quick response.
Adam Richter
Signed-off-by: Adam J. Richter <adam_richter2004@xxxxxxxxx>
--- linux-2.6.29-rc5/drivers/usb/class/cdc-acm.c 2009-02-13 15:31:30.000000000 -0800
+++ linux-2.6.29-rc5.hummingbird-modem/drivers/usb/class/cdc-acm.c 2009-02-17 16:18:24.000000000 -0800
@@ -1376,6 +1376,13 @@
{ USB_DEVICE(0x0572, 0x1324), /* Conexant USB MODEM RD02-D400 */
.driver_info = NO_UNION_NORMAL, /* has no union descriptor */
},
+ { USB_DEVICE(0x0572, 0x1329), /* Hummingbird huc56s (Conexant) */
+ .driver_info = NO_UNION_NORMAL, /* union descriptor misplaced on
+ data interface instead of
+ communications interface.
+ Maybe we should define a new
+ quirk for this. */
+ },
/* control interfaces with various AT-command sets */
{ USB_INTERFACE_INFO(USB_CLASS_COMM, USB_CDC_SUBCLASS_ACM,
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
