Re: [PATCH v2 6/7] usb: musb: fix runtime PM in debugfs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 09, 2017 at 07:21:03AM -0600, Bin Liu wrote:
> Greg,
> 
> On Thu, Jan 05, 2017 at 12:33:02PM -0600, Bin Liu wrote:
> > On Thu, Jan 05, 2017 at 07:17:51PM +0100, Greg KH wrote:
> > > On Tue, Jan 03, 2017 at 06:13:51PM -0600, Bin Liu wrote:
> > > > MUSB driver now has runtime PM support, but the debugfs driver misses
> > > > the PM _get/_put() calls, which could cause MUSB register access
> > > > failure.
> > > > 
> > > > Cc: stable@xxxxxxxxxxxxxxx # 4.9+
> > > > Signed-off-by: Bin Liu <b-liu@xxxxxx>
> > > > Acked-by: Tony Lindgren <tony@xxxxxxxxxxx>
> > > > ---
> > > > v2: no change.
> > > > 
> > > >  drivers/usb/musb/musb_debugfs.c | 20 +++++++++++++++++++-
> > > >  1 file changed, 19 insertions(+), 1 deletion(-)
> > > 
> > > This looks like a new feature, it's never worked before, why add it now?
> > > 
> > This is not a new feature, but fixing the PM regression. musb has
> > runtime PM added back in v4.9, but forgot to add the PM calls in
> > the debugfs driver, which causes all the musb debugfs interface not
> > functional.
> 
> Do you want me to resend it for -rc4, or keep it until v4.11-rc1?
> This fixes a regression in v4.9.

You can resend.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux