Re: [PATCH] wusb: Storage class should be before const qualifier

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jiri Kosina wrote:
> On Mon, 9 Feb 2009, Tobias Klauser wrote:
> 
>> The C99 specification states in section 6.11.5:
>>
>> The placement of a storage-class specifier other than at the beginning
>> of the declaration specifiers in a declaration is an obsolescent
>> feature.
>>
>> Signed-off-by: Tobias Klauser <tklauser@xxxxxxxxxx>
>> ---
>>  include/linux/usb/wusb.h |    3 +--
>>  1 files changed, 1 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/linux/usb/wusb.h b/include/linux/usb/wusb.h
>> index 5f401b6..429c631 100644
>> --- a/include/linux/usb/wusb.h
>> +++ b/include/linux/usb/wusb.h
>> @@ -80,8 +80,7 @@ struct wusb_ckhdid {
>>  	u8 data[16];
>>  } __attribute__((packed));
>>  
>> -const static
>> -struct wusb_ckhdid wusb_ckhdid_zero = { .data = { 0 } };
>> +static const struct wusb_ckhdid wusb_ckhdid_zero = { .data = { 0 } };
>>  
>>  #define WUSB_CKHDID_STRSIZE (3 * sizeof(struct wusb_ckhdid) + 1)
> 
> David, are you going to take this through wusb tree, or should I take it 
> through trivial tree together with the rest of these patches? I don't seem 
> to see this present in current -next.

Through trivial is best I think, thanks.  You can add

Acked-by: David Vrabel <david.vrabel@xxxxxxx>

if you wish.

David
-- 
David Vrabel, Senior Software Engineer, Drivers
CSR, Churchill House, Cambridge Business Park,  Tel: +44 (0)1223 692562
Cowley Road, Cambridge, CB4 0WZ                 http://www.csr.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux