On Fri, Jan 06, 2017 at 01:29:49PM -0600, Bin Liu wrote: > The dsps glue uses PLATFORM_DEVID_AUTO when creating the musb-hdrc > platform devices, this causes that the id will change in each system > depending on the order of driver probe, the order of the usb instances > defined in device-tree, or the list of enabled devices which use also > PLATFORM_DEVID_AUTO in kernel config. This id inconsistency causes > trouble in shell scripting or user guide documentation. The discussion about this issue is in [1]. [1] http://marc.info/?t=144009145200001&r=1&w=2 Regards, -Bin. > > So switch it to static id, starting from 0 to the musb instance with > lower MMR offset. This scheme is also aligned to the naming in the SoC. > > Signed-off-by: Bin Liu <b-liu@xxxxxx> > --- > drivers/usb/musb/musb_dsps.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c > index c722daddfb67..f7b3cb1aea6b 100644 > --- a/drivers/usb/musb/musb_dsps.c > +++ b/drivers/usb/musb/musb_dsps.c > @@ -683,7 +683,8 @@ static int dsps_create_musb_pdev(struct dsps_glue *glue, > resources[1] = *res; > > /* allocate the child platform device */ > - musb = platform_device_alloc("musb-hdrc", PLATFORM_DEVID_AUTO); > + musb = platform_device_alloc("musb-hdrc", > + (resources[0].start & 0xFFF) == 0x400 ? 0 : 1); > if (!musb) { > dev_err(dev, "failed to allocate musb device\n"); > return -ENOMEM; > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
