Re: [PATCH v2 5/7] usb: musb: debugfs: allow forcing host mode together with speed in testmode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 05, 2017 at 12:29:21PM -0600, Bin Liu wrote:
> On Thu, Jan 05, 2017 at 07:17:14PM +0100, Greg KH wrote:
> > On Tue, Jan 03, 2017 at 06:13:50PM -0600, Bin Liu wrote:
> > > From: Pali Rohár <pali.rohar@xxxxxxxxx>
> > > 
> > > Based on the musb ug, force_host bit is allowed to be set along with
> > > force_hs or force_fs bit.
> > > 
> > > It could help to implement forced host mode via testmode on Nokia N900.
> > > 
> > > Signed-off-by: Pali Rohár <pali.rohar@xxxxxxxxx>
> > > Signed-off-by: Bin Liu <b-liu@xxxxxx>
> > > ---
> > > v2: no change.
> > > 
> > >  drivers/usb/musb/musb_debugfs.c | 46 ++++++++++++++++++++++++++---------------
> > >  1 file changed, 29 insertions(+), 17 deletions(-)
> > 
> > Why is this a 4.10-rc change?  It implements a new feature, it's not a
> > regression fix, right?
> 
> No, it is not for a new feature, but fixes the driver to align with the
> hw manual, so that the musb host can be functional (again) on N900.

But if it never worked before, this isn't the time to fix it...

> N900 musb used to work, but some time ago (2015/2016?) the musb debugfs
> driver was modified to eliminate the possibility of usb test mode abuse,
> but the change breaks N900 musb host function.

Then it can wait until 4.11-rc1, right?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux