Re: [PATCH 4/4] usb: xhci: remove unnecessary return in xhci_pci_setup()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 01/05/2017 02:12 AM, Andy Shevchenko wrote:
> On Wed, Jan 4, 2017 at 3:51 AM, Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx> wrote:
>> Remove the unnecessary return line in xhci_pci_setup().
>>
>> Signed-off-by: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>
>> ---
>>  drivers/usb/host/xhci-pci.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
>> index e96ae80..ace3f57 100644
>> --- a/drivers/usb/host/xhci-pci.c
>> +++ b/drivers/usb/host/xhci-pci.c
>> @@ -242,8 +242,6 @@ static int xhci_pci_setup(struct usb_hcd *hcd)
>>
>>         /* Find any debug ports */
>>         retval = xhci_pci_reinit(xhci, pdev);
>> -       if (!retval)
>> -               return retval;
>>
>>         return retval;
> Then better just
>
> return xhci_pci_reinit(xhci, pdev);
>

Fair enough. Thanks.

Best regards,
Lu Baolu
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux