Dear Krzysztof, I posted new version and it's improved thanks to your review. About introducing usbip_meta_driver_.*(), I decided not to use _meta_. In this series, it becomes an abstraction among daemons so _meta_ is too much for it. usbipd_ prefix has been used so I thought usbipd_driver_.*() is fit to this case. Thank you for your help, nobuo iwata // > -----Original Message----- > From: Krzysztof Opasiak [mailto:k.opasiak@xxxxxxxxxxx] > Sent: Wednesday, December 07, 2016 5:57 PM > To: fx IWATA NOBUO <Nobuo.Iwata@xxxxxxxxxxxxxxx>; > valentina.manea.m@xxxxxxxxx; shuah.kh@xxxxxxxxxxx; > gregkh@xxxxxxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx > Cc: fx MICHIMURA TADAO <MICHIMURA.Tadao@xxxxxxxxxxxxxxx> > Subject: Re: [PATCH v13 05/10] usbip: exporting devices: modifications to > daemon > > > > On 12/07/2016 01:05 AM, fx IWATA NOBUO wrote: > > Hello, > > > >> how about usbip_meta_driver_set(type)? > > > > Good. > > > > I'd like to confirm the 'type' parameter. > > > > #define USBIP_DRIVER_TYPE_HOST 0 > > #define USBIP_DRIVER_TYPE_DEVICE 1 > > > > Then usbip_meta_driver_init should not be included. > > It must be usbip_meta_driver_set(USBIP_DRIVER_TYPE_HOST). > > > > Yes, that's exactly what I mean. > > Best regards, > -- > Krzysztof Opasiak > Samsung R&D Institute Poland > Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
