On Tue, Jan 03, 2017 at 09:07:05PM +0200, Felipe Balbi wrote: [...] > >> IOW, since you're Ccing stable, you consider this to be a > >> regression. Then the question reads as: "Are you missing a 'Fixes: foo > >> bar baz' in your commit log?" > > > > I think it is difficult to find out the commit to blame, so I used 'cc > > stable' tag, not 'Fixes:...'. Any recommendation for better logging it? > > you could have used MUSB's first commit for Fixes :-) Then it becomes > clear that the issue has always existed. I was trying to avoid this as I don't like any musb core change in a kernel which I cannot test it ;) > > Also, you could have mentioned after tear line (---) that the issue has > always existed, but you only tested back to v4.1 and it's unlikely to > have any users MUSB on older kernels anyway. Yeah, this was my bad, I only mentioned this in the cover letter when sending this fix months ago. Now I logged this in the commit message in v2 [1] I just sent a moment ago. Please let me know if you have any comments. [1] http://marc.info/?l=linux-usb&m=148346809013956&w=2 http://marc.info/?l=linux-usb&m=148346809913963&w=2 http://marc.info/?l=linux-usb&m=148346809113958&w=2 Thanks, -Bin. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
