Re: [PATCH] fsl_usb2_udc: fix potential queue head corruption

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday 13 February 2009, Li Yang wrote:
> Clear next TD field and status field in queue head initialization code
> to prevent unpredictable result caused by residue of usb reset.
> 
> Signed-off-by: Li Yang <leoli@xxxxxxxxxxxxx>

Acked-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>

... wanted for 2.6.29-rc, right?

> ---
>  drivers/usb/gadget/fsl_usb2_udc.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/usb/gadget/fsl_usb2_udc.c b/drivers/usb/gadget/fsl_usb2_udc.c
> index 5ae5cb7..ec2640f 100644
> --- a/drivers/usb/gadget/fsl_usb2_udc.c
> +++ b/drivers/usb/gadget/fsl_usb2_udc.c
> @@ -419,7 +419,10 @@ static void struct_ep_qh_setup(struct fsl_udc *udc, unsigned char ep_num,
>  	}
>  	if (zlt)
>  		tmp |= EP_QUEUE_HEAD_ZLT_SEL;
> +
>  	p_QH->max_pkt_length = cpu_to_le32(tmp);
> +	p_QH->next_dtd_ptr = 1;
> +	p_QH->size_ioc_int_sts = 0;
>  
>  	return;
>  }
> -- 
> 1.5.5.1.248.g4b17
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux