Re: [PATCH 2/2] usb: gadget: printer: Remove pnp_string static buffer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Krzysztof,

[auto build test WARNING on balbi-usb/next]
[also build test WARNING on v4.9 next-20161220]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Krzysztof-Opasiak/usb-gadget-ether-Add-n-to-each-attribute-of-ethernet-functions/20161221-070119
base:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: openrisc-allmodconfig (attached as .config)
compiler: or32-linux-gcc (GCC) 4.5.1-or32-1.0rc1
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=openrisc 

All warnings (new ones prefixed by >>):

   drivers/usb/gadget/legacy/printer.c: In function 'printer_bind':
>> drivers/usb/gadget/legacy/printer.c:161:3: warning: statement with no effect

vim +161 drivers/usb/gadget/legacy/printer.c

   145		struct f_printer_opts *opts;
   146		int ret;
   147	
   148		fi_printer = usb_get_function_instance("printer");
   149		if (IS_ERR(fi_printer))
   150			return PTR_ERR(fi_printer);
   151	
   152		opts = container_of(fi_printer, struct f_printer_opts, func_inst);
   153		opts->minor = 0;
   154		opts->q_len = QLEN;
   155		if (iPNPstring) {
   156			opts->pnp_string = kstrdup(iPNPstring, GFP_KERNEL);
   157			if (!opts->pnp_string) {
   158				ret = -ENOMEM;
   159				goto fail_put_func_inst;
   160			}
 > 161			opts->pnp_string_allocated;
   162			/*
   163			 * we don't free this memory in case of error
   164			 * as printer cleanup func will do this for us
   165			 */
   166		} else {
   167			opts->pnp_string = pnp_string;
   168		}
   169	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux