On Fri, Dec 16, 2016 at 07:19:40PM -0500, Jérémy Lefaure wrote:
> Commit cc92f6818f6e ("usb: musb: Populate new IO functions for
> blackfin") defines bfin_fifo_offset function without using it:
Please use 'Fixes:' comment style.
Regards,
-Bin.
>
> drivers/usb/musb/blackfin.c:36:12: warning: ‘bfin_fifo_offset’ defined
> but not used [-Wunused-function]
> static u32 bfin_fifo_offset(u8 epnum)
> ^~~~~~~~~~~~~~~~
>
> Adding bfin_fifo_offset to bfin_ops fixes this warning and allows musb
> core to call this function instead of default_fifo_offset.
>
> Signed-off-by: Jérémy Lefaure <jeremy.lefaure@xxxxxxxxxxxx>
> ---
> drivers/usb/musb/blackfin.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/musb/blackfin.c b/drivers/usb/musb/blackfin.c
> index f43edc43268b..4418574a36a1 100644
> --- a/drivers/usb/musb/blackfin.c
> +++ b/drivers/usb/musb/blackfin.c
> @@ -469,6 +469,7 @@ static const struct musb_platform_ops bfin_ops = {
> .init = bfin_musb_init,
> .exit = bfin_musb_exit,
>
> + .fifo_offset = bfin_fifo_offset,
> .readb = bfin_readb,
> .writeb = bfin_writeb,
> .readw = bfin_readw,
> --
> 2.11.0
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
