Hi, Jerry Huang <jerry.huang@xxxxxxx> writes: >> >> Jerry Huang <jerry.huang@xxxxxxx> writes: >> >> >> there's no need for that. This patch is in good format. I do have >> >> >> a question, >> >> >> however: how do you know this will work for all users? Burst size >> >> >> is a function of how wide the interconnect where dwc3 is attached to, >> is. >> >> > So I need to generate one new property in usb node to identify my >> >> platform? >> >> >> >> Well, we probably need a property to be passed, yes. But let's go >> >> through it all first :-) >> > >> > I think "snps,quirk-frame-length-adjustment" is one good reference, >> > which can pass the required value to driver from DTS file. >> >> that's not for burst increment, though. > > I created one new property " snps,incr-burst-type-adjustment = <x>, > <y>" to identify it from usb node, and will send out the v3 patch. okay, don't forget to Cc devicetree@xxxxxxxxxxxxxxx. Let's see what those guys say. >> > So, after enable undefined length INCR burst and enable INCR16, >> > controller will use less than or equal to 16byte. >> > >> >> Only Undefined INCR will be taken into consideration. Can you check >> >> with your HW engineers what's the largest burst the interconnect is >> >> supposed to support? >> > I will check it with IP designer. >> >> cool, thanks :-) > > Have confirmed with hardware engineer, the maximum INCR burst size of > NXP platform is 16 byte good, thanks for that. -- balbi
Attachment:
signature.asc
Description: PGP signature
