On Friday 23 January 2009, Felipe Balbi wrote: > On Fri, Nov 14, 2008 at 06:51:02PM +0530, Anand Gadiyar wrote: > > From: Anand Gadiyar <gadiyar@xxxxxx> > > > > If this is not done, khubd will not be informed of the disconnect > > and will assume the device is still there. > > > > Easily seen when a hub is connected with no device attached to it - > > it will autosuspend. When the hub is disconnected, it still shows > > up in /proc/bus/usb/devices > > > > Signed-off-by: Anand Gadiyar <gadiyar@xxxxxx> > > i can't see a problem with this patch. Dave ?? > > If dave is also ok with this one: > > Acked-by: Felipe Balbi <felipe.balbi@xxxxxxxxx> > > > --- > > I'm not sure if this is the right place to call usb_hcd_resume_root_hub() > > or if this should be done within musb_root_disconnect(). I'm not sure either, but if this way is tested then let's do it this way. It may need updates later, for OTG etc, but we'll deal with this then. I'll send a cleaner email with this patch and my s-o-b. > > > > diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c > > index 4a35745..1a00370 100644 > > --- a/drivers/usb/musb/musb_core.c > > +++ b/drivers/usb/musb/musb_core.c > > @@ -766,6 +766,7 @@ static irqreturn_t musb_stage2_irq(struct musb *musb, u8 int_usb, > > #ifdef CONFIG_USB_MUSB_HDRC_HCD > > case OTG_STATE_A_HOST: > > case OTG_STATE_A_SUSPEND: > > + usb_hcd_resume_root_hub(musb_to_hcd(musb)); > > musb_root_disconnect(musb); > > if (musb->a_wait_bcon != 0) > > musb_platform_try_idle(musb, jiffies > -- > balbi > > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
