Re: [PATCH] usb: musb: use 32-bit variable for fifo_count

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday 11 February 2009, Felipe Balbi wrote:
> request->actual is an unsigned and we should use the same
> variable type for fifo_count otherwise we might loose some
> data if request->length >= 64kbytes.
> 
> Cc: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>

Acked-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>

... seems like 2.6.29-rc fix to me.

> Signed-off-by: Felipe Balbi <felipe.balbi@xxxxxxxxx>
> ---
>  drivers/usb/musb/musb_gadget.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c
> index 4ea3053..e7f8354 100644
> --- a/drivers/usb/musb/musb_gadget.c
> +++ b/drivers/usb/musb/musb_gadget.c
> @@ -575,7 +575,7 @@ static void rxstate(struct musb *musb, struct musb_request *req)
>  	struct usb_request	*request = &req->request;
>  	struct musb_ep		*musb_ep = &musb->endpoints[epnum].ep_out;
>  	void __iomem		*epio = musb->endpoints[epnum].regs;
> -	u16			fifo_count = 0;
> +	unsigned		fifo_count = 0;
>  	u16			len = musb_ep->packet_sz;
>  
>  	csr = musb_readw(epio, MUSB_RXCSR);
> -- 
> 1.6.1.265.g9a013
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux