Re: [PATCH 4/9] musb_host: fix endpoint_disable() method (take 2)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday 11 February 2009, Sergei Shtylyov wrote:
> > Answer to my question:  because one branch must advance
> > the bulk or control queue the endpoint was on, but the
> > other branch doesn't.
> 
>    Yes. The other branch also must not call musb_giveback() because thel 
> latter assumes to be called on active qh and will e.g. spoil the saved 
> toggle state otherwise.

Saved toggle state is never-no-mind in this function
though, since the endpoint is going away.

That might change in the future, if we grow some sort
of "just empty the queue" method instead of the current
"empty queue and disable endpoint".

- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux