Hi,
Bjorn Helgaas <helgaas@xxxxxxxxxx> writes:
> Hi Mathias,
>
> ehci_irq(), ohci_irq(), fotg210_irq(), and oxu210_hcd_irq() contain code
> equivalent to this:
>
> status = ehci_readl(...);
> if (status == ~(u32) 0) {
> ...
> usb_hc_died(hcd);
> ...
> return IRQ_HANDLED;
> }
>
> xhci_irq() has a similar check, but does not call usb_hc_died():
>
> status = readl(...);
> if (status = 0xffffffff) {
> ...
> return IRQ_HANDLED;
> }
>
> Should xhci_irq() also call usb_hc_died()? Maybe there's some reason
> for it to be different than the others, but it wasn't obvious to this
> casual observer :)
you might just have fixed several bugs in dealing with a dead HC :-)
Can you provide a patch? (well, unless Mathias has a strong reason not
to call usb_hc_died(), of course).
--
balbi
Attachment:
signature.asc
Description: PGP signature
