Hello.
David Brownell wrote:
The EP0 code routinely ignores interrupt at end of the data phase because of
musb_g_ep0_giveback() resetting the state machine to "idle, waiting for SETUP"
phase prematurely.
Signed-off-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>
Does this depend on any preceding patches?
Preceding patches don't touch this file, if you haven't noticed.
---
This fixes most of the unhandled gadget interrupts that generic_interrupt() and
davinci_interrupt() have been hiding from user by faking their result and only
emitting 5th level debug message (for what is clearly an error).
So, this should then remove the comment and DBG() from the
davinci_interrupt() and generic_interrupt() IRQ handlers,
and stop always returning IRQ_HANDLED.
Well, that's another problem. But if you insist, I can do that.
I'm not sure I'd agree this is a "must fix for 2.6.29" bug.
What problems does it cause ... other than a low priority
debug message appearing,
Low priority debug message where the error message was more
appropriate, you mean? :-)
when such messages are cranked up
to a "serious impact on usability" level? How did you
reproduce the problem?
By *not* ignoring the musb_interrupt() return value on OMAP-L137 --
and doing t for a good reason. :-(
ISTR this seemed harmless, which is why its diagnostic was
low priority and the mess only got a "REVISIT" comment.
Which had never been revisited of course, until I had to look into it
. :-)
- Dave
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
